Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TTN Mapper template #21

Merged
merged 3 commits into from
Mar 22, 2021
Merged

Conversation

jpmeijers
Copy link
Contributor

Summary

Closes #14

Depends on #20, #17 and #18 to be solved, but for now it's still usable, albeit with a smaller feature set.

Changes

  • Add template for TTN Mapper
  • Add reference to templates list

Notes for Reviewers

Commented out code which adds a field for the experiment ID is there until #17 can be solved. At that point we can enable those lines again.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible, they don't break existing deployments.
  • Testing: The changes are tested. -- tested against a private hosted v3.11.2 stack.
  • Documentation: Relevant documentation is added or updated.

@nejraselimovic nejraselimovic self-requested a review March 19, 2021 09:10
@nejraselimovic
Copy link
Contributor

@jpmeijers is there any documentation about integrating TTNMapper with V3? If not, could you create something I could use for our documentation page?

@jpmeijers
Copy link
Contributor Author

I'll be hosting the documentation on TTN Mapper's side, as defined in the template: https://ttnmapper.org/docs/tts/v3/

The documentation is currently only a placeholder, but I plan to write it as soon as I know if the webhook template is accepted in its current form or not.

@jpmeijers
Copy link
Contributor Author

Old documentation on which we can base the new docs:
https://www.thethingsnetwork.org/docs/applications/ttnmapper/index.html

ttnmapper.yml Outdated Show resolved Hide resolved
@nejraselimovic
Copy link
Contributor

nejraselimovic commented Mar 19, 2021

Old documentation on which we can base the new docs:
https://www.thethingsnetwork.org/docs/applications/ttnmapper/index.html

Thank you for the info. This template looks fine to me, just remove the dot in description to keep it consistent with other templates, and let's keep going with the documentation and fixes you proposed.

jpmeijers and others added 2 commits March 19, 2021 17:25
Co-authored-by: Nejra Selimović <nejra.selimovic@thethingsindustries.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TTN Mapper
2 participants